[libunwind] Revert "Silence -Wunused-parameter warnings in Unwind-wasm.c" (PR #175776)
Sam Clegg via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 13 07:14:04 PST 2026
https://github.com/sbc100 created https://github.com/llvm/llvm-project/pull/175776
Reverts llvm/llvm-project#125412
See the discussion in #125412 for why this is necessary. The summary is that:
- Eliding arguments is the C23 extension
- `-Wno-unused-parameter` is part of the build for libunwind, so the codebase does allow them.
>From 513c29f11c8d97309f5bb6219ea00a0030494c30 Mon Sep 17 00:00:00 2001
From: Sam Clegg <sbc at chromium.org>
Date: Tue, 13 Jan 2026 07:12:29 -0800
Subject: [PATCH] =?UTF-8?q?Revert=20"[libunwind]=20Silence=20-Wunused-para?=
=?UTF-8?q?meter=20warnings=20in=20Unwind-wasm.c=20(#12=E2=80=A6"?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This reverts commit f4206f92c5f900a4e0fc0f6dcab6afb6865df1e9.
---
libunwind/src/Unwind-wasm.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libunwind/src/Unwind-wasm.c b/libunwind/src/Unwind-wasm.c
index b0d6cd2d00fc5..2f4498c3f3989 100644
--- a/libunwind/src/Unwind-wasm.c
+++ b/libunwind/src/Unwind-wasm.c
@@ -102,7 +102,8 @@ _LIBUNWIND_EXPORT uintptr_t _Unwind_GetIP(struct _Unwind_Context *context) {
}
/// Not used in Wasm.
-_LIBUNWIND_EXPORT void _Unwind_SetIP(struct _Unwind_Context *, uintptr_t) {}
+_LIBUNWIND_EXPORT void _Unwind_SetIP(struct _Unwind_Context *context,
+ uintptr_t value) {}
/// Called by personality handler to get LSDA for current frame.
_LIBUNWIND_EXPORT uintptr_t
@@ -114,7 +115,8 @@ _Unwind_GetLanguageSpecificData(struct _Unwind_Context *context) {
}
/// Not used in Wasm.
-_LIBUNWIND_EXPORT uintptr_t _Unwind_GetRegionStart(struct _Unwind_Context *) {
+_LIBUNWIND_EXPORT uintptr_t
+_Unwind_GetRegionStart(struct _Unwind_Context *context) {
return 0;
}
More information about the cfe-commits
mailing list