[clang] Revert "[clang-format] Annotate ::operator and Foo::operator correctly" (PR #164670)

[Eli Friedman via cfe-commits]

efriedma-quic wrote:

> The recent activity here is https://github.com/llvm/llvm-project/pull/164048, then https://github.com/llvm/llvm-project/pull/164670, then https://github.com/llvm/llvm-project/commit/a948f25142e21e60594c6d24e2851f1ff3f216be?

As far as I can tell, what happened is @owenca committed a patch on Oct 17, which broke a workflow for @PiJoules on Oct 21.  He asked for a immediate fix/revert, which did not happen, then he reverted on Oct 22.  After that point, this turned into a revert war.  Currently, the Oct 17 patch is in.

There's also some discussion of a patch which landed last year, but from my perspective it's not relevant.

----

I apologize for not being 100% explicit about what I expected to happen in my previous message.

In the interest of resolving the immediate breakage quickly without further devolving into revert wars, I'm going to be extremely explicit here:

@owenca You have 48 hours from now to resolve the issue @pijoules reported against main.  Either revert to the state before Oct 17, or fix the issue.  If you don't solve it within 48 hours from this message (deadline is 10pm pdt Monday Oct 27), you're not allowed to touch anything related to this issue without getting approval from @PiJoules or me.  Please acknowledge this as soon as you see it.

@PiJoules Don't do anything for 48 hours.  After the deadline, you can revert to the state before Oct 17.

-----

After this is resolved, let's have a Discourse discussion to figure out how we can avoid future revert wars.

https://github.com/llvm/llvm-project/pull/164670