[libclc] [libclc] Only create a target per each compile command for cmake MSVC generator (PR #154479)

Fraser Cormack via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 20 02:22:36 PDT 2025


================
@@ -132,6 +124,33 @@ function(link_bc)
   )
 endfunction()
 
+# Create a custom target for each bitcode file, which is the output of a custom
+# command. This is required for parallel compilation of the custom commands that
+# generate the bitcode files when using the CMake MSVC generator on Windows.
+#
+# Arguments:
+#  * compile_tgts
+#      Output list of compile targets
+#  * ARCH_SUFFIX <string>
+#      libclc architecture/triple suffix
+#  * FILES <string> ...
+#     List of bitcode files
+function(create_compile_targets compile_tgts)
+  cmake_parse_arguments( ARG "" "ARCH_SUFFIX" "FILES" ${ARGN} )
----------------
frasercrmck wrote:

Perhaps we should error if `ARCH_SUFFIX` is empty? Just thinking that `compile--*` looks unintentional. Maybe an empty `FILES` is okay, maybe not.

https://github.com/llvm/llvm-project/pull/154479


More information about the cfe-commits mailing list