[clang-tools-extra] [clang-tidy] Fix linking regression in clangTidyLLVMModule (PR #150769)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang-tidy

Author: Michał Górny (mgorny)

<details>
<summary>Changes</summary>

Fix the regression introduced in #<!-- -->149148 that incorrectly explicitly linked `clangTransformer` when dylib was used.  As a result, the executables linking to `clangTidyLLVMModule` would end up linking both the dylib and a number of static clang libraries, leading to complete mayhem and undecipherable segmentation faults.

---
Full diff: https://github.com/llvm/llvm-project/pull/150769.diff


1 Files Affected:

- (modified) clang-tools-extra/clang-tidy/llvm/CMakeLists.txt (+1-1) 


``````````diff
diff --git a/clang-tools-extra/clang-tidy/llvm/CMakeLists.txt b/clang-tools-extra/clang-tidy/llvm/CMakeLists.txt
index 4f1da43d3f1b7..41386cdb55b1f 100644
--- a/clang-tools-extra/clang-tidy/llvm/CMakeLists.txt
+++ b/clang-tools-extra/clang-tidy/llvm/CMakeLists.txt
@@ -17,7 +17,6 @@ add_clang_library(clangTidyLLVMModule STATIC
   clangTidy
   clangTidyReadabilityModule
   clangTidyUtils
-  clangTransformer
 
   DEPENDS
   omp_gen
@@ -31,4 +30,5 @@ clang_target_link_libraries(clangTidyLLVMModule
   clangBasic
   clangLex
   clangTooling
+  clangTransformer
   )

``````````

</details>


https://github.com/llvm/llvm-project/pull/150769