[clang-tools-extra] [clang-tidy] Fix linking regression in clangTidyLLVMModule (PR #150769)

[Michał Górny via cfe-commits]

https://github.com/mgorny created https://github.com/llvm/llvm-project/pull/150769

Fix the regression introduced in #149148 that incorrectly explicitly linked `clangTransformer` when dylib was used.  As a result, the executables linking to `clangTidyLLVMModule` would end up linking both the dylib and a number of static clang libraries, leading to complete mayhem and undecipherable segmentation faults.

>From 0c5c30492a007aeb7f40121d44dc0096a0796dbf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= <mgorny at gentoo.org>
Date: Sat, 26 Jul 2025 16:58:10 +0200
Subject: [PATCH] [clang-tidy] Fix linking regression in clangTidyLLVMModule
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fix the regression introduced in #149148 that incorrectly explicitly
linked `clangTransformer` when dylib was used.  As a result,
the executables linking to `clangTidyLLVMModule` would end up linking
both the dylib and a number of static clang libraries, leading to
complete mayhem and undecipherable segmentation faults.

Signed-off-by: Michał Górny <mgorny at gentoo.org>
---
 clang-tools-extra/clang-tidy/llvm/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang-tools-extra/clang-tidy/llvm/CMakeLists.txt b/clang-tools-extra/clang-tidy/llvm/CMakeLists.txt
index 4f1da43d3f1b7..41386cdb55b1f 100644
--- a/clang-tools-extra/clang-tidy/llvm/CMakeLists.txt
+++ b/clang-tools-extra/clang-tidy/llvm/CMakeLists.txt
@@ -17,7 +17,6 @@ add_clang_library(clangTidyLLVMModule STATIC
   clangTidy
   clangTidyReadabilityModule
   clangTidyUtils
-  clangTransformer
 
   DEPENDS
   omp_gen
@@ -31,4 +30,5 @@ clang_target_link_libraries(clangTidyLLVMModule
   clangBasic
   clangLex
   clangTooling
+  clangTransformer
   )