[clang] [Clang][ByteCode][NFC] Move APInt into pushInteger since it is being passed by value (PR #143578)
Shafik Yaghmour via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 10 13:16:55 PDT 2025
https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/143578
>From 09060e9a91842346f106d55b32141b16efe7378d Mon Sep 17 00:00:00 2001
From: Shafik Yaghmour <shafik.yaghmour at intel.com>
Date: Tue, 10 Jun 2025 10:41:04 -0700
Subject: [PATCH 1/2] [Clang][ByteCode][NFC] Move APInt into pushInteger since
it is being passed by value
Static analysis flagged that we could move APInt instead of copy, indeed it has
a move constructor and so we should move into values for APInt.
---
clang/lib/AST/ByteCode/InterpBuiltin.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/clang/lib/AST/ByteCode/InterpBuiltin.cpp b/clang/lib/AST/ByteCode/InterpBuiltin.cpp
index b678f229d50bb..5fc5034569597 100644
--- a/clang/lib/AST/ByteCode/InterpBuiltin.cpp
+++ b/clang/lib/AST/ByteCode/InterpBuiltin.cpp
@@ -1321,7 +1321,7 @@ static bool interp__builtin_ia32_pdep(InterpState &S, CodePtr OpPC,
if (Mask[I])
Result.setBitVal(I, Val[P++]);
}
- pushInteger(S, Result, Call->getType());
+ pushInteger(S, std::move(Result), Call->getType());
return true;
}
@@ -1344,7 +1344,7 @@ static bool interp__builtin_ia32_pext(InterpState &S, CodePtr OpPC,
if (Mask[I])
Result.setBitVal(P++, Val[I]);
}
- pushInteger(S, Result, Call->getType());
+ pushInteger(S, std::move(Result), Call->getType());
return true;
}
>From 13a3055b7a180f218bad55d426db8958a410fd1d Mon Sep 17 00:00:00 2001
From: Shafik Yaghmour <shafik.yaghmour at intel.com>
Date: Tue, 10 Jun 2025 13:16:45 -0700
Subject: [PATCH 2/2] Trigger Build
More information about the cfe-commits
mailing list