[clang] [Clang][ByteCode][NFC] Move APInt into pushInteger since it is being passed by value (PR #143578)
via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 10 11:10:51 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Shafik Yaghmour (shafik)
<details>
<summary>Changes</summary>
Static analysis flagged that we could move APInt instead of copy, indeed it has a move constructor and so we should move into values for APInt.
---
Full diff: https://github.com/llvm/llvm-project/pull/143578.diff
1 Files Affected:
- (modified) clang/lib/AST/ByteCode/InterpBuiltin.cpp (+2-2)
``````````diff
diff --git a/clang/lib/AST/ByteCode/InterpBuiltin.cpp b/clang/lib/AST/ByteCode/InterpBuiltin.cpp
index b678f229d50bb..5fc5034569597 100644
--- a/clang/lib/AST/ByteCode/InterpBuiltin.cpp
+++ b/clang/lib/AST/ByteCode/InterpBuiltin.cpp
@@ -1321,7 +1321,7 @@ static bool interp__builtin_ia32_pdep(InterpState &S, CodePtr OpPC,
if (Mask[I])
Result.setBitVal(I, Val[P++]);
}
- pushInteger(S, Result, Call->getType());
+ pushInteger(S, std::move(Result), Call->getType());
return true;
}
@@ -1344,7 +1344,7 @@ static bool interp__builtin_ia32_pext(InterpState &S, CodePtr OpPC,
if (Mask[I])
Result.setBitVal(P++, Val[I]);
}
- pushInteger(S, Result, Call->getType());
+ pushInteger(S, std::move(Result), Call->getType());
return true;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/143578
More information about the cfe-commits
mailing list