[clang] [cmake] Reenable libclang.dll on Windows when LLVM_ENABLE_PIC (PR #138343)

via cfe-commits cfe-commits at lists.llvm.org
Fri May 2 13:43:37 PDT 2025


================
@@ -106,7 +106,7 @@ if (LLVM_EXPORTED_SYMBOL_FILE)
                      DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE})
 endif()
 
-if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR
+if((NOT CYGWIN AND LLVM_ENABLE_PIC) OR
   ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUILD_STATIC))
----------------
jeremyd2019 wrote:

I'd just do
```suggestion
if(LLVM_ENABLE_PIC OR ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUILD_STATIC))
```

since `LIBCLANG_BUILD_STATIC` is documented to build a static libclang *in addition to* the shared libclang

https://github.com/llvm/llvm-project/pull/138343


More information about the cfe-commits mailing list