[clang] [cmake] Reenable libclang.dll on Windows when LLVM_ENABLE_PIC (PR #138343)
via cfe-commits
cfe-commits at lists.llvm.org
Fri May 2 13:41:47 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Arthur Eubanks (aeubanks)
<details>
<summary>Changes</summary>
This was accidentally disabled in #<!-- -->138119 for non-mingw Windows.
---
Full diff: https://github.com/llvm/llvm-project/pull/138343.diff
1 Files Affected:
- (modified) clang/tools/libclang/CMakeLists.txt (+1-1)
``````````diff
diff --git a/clang/tools/libclang/CMakeLists.txt b/clang/tools/libclang/CMakeLists.txt
index 37a939ffcada7..8fbee71e02882 100644
--- a/clang/tools/libclang/CMakeLists.txt
+++ b/clang/tools/libclang/CMakeLists.txt
@@ -106,7 +106,7 @@ if (LLVM_EXPORTED_SYMBOL_FILE)
DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE})
endif()
-if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR
+if((NOT CYGWIN AND LLVM_ENABLE_PIC) OR
((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUILD_STATIC))
set(ENABLE_SHARED SHARED)
endif()
``````````
</details>
https://github.com/llvm/llvm-project/pull/138343
More information about the cfe-commits
mailing list