[clang] [analyzer] Partial revert of #127017 (PR #128642)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang-static-analyzer-1

Author: Balazs Benics (steakhal)

<details>
<summary>Changes</summary>

This assertion was hit, as reported by a user.
https://github.com/llvm/llvm-project/issues/128427#issuecomment-2677724438

Ideally, we would reduce and add a regression test for this, but I don't have the bandwidth for it.

See the summary of the issue #<!-- -->128427 for the reproducer.

---
Full diff: https://github.com/llvm/llvm-project/pull/128642.diff


1 Files Affected:

- (modified) clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp (-1) 


``````````diff
diff --git a/clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp
index 8955cb209c399..12bf12a0b2322 100644
--- a/clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp
@@ -314,7 +314,6 @@ void MacOSKeychainAPIChecker::checkPreStmt(const CallExpr *CE,
     RegionArgIsBad = true;
   }
 
-  assert(ArgSM);
   // Is the argument to the call being tracked?
   const AllocationState *AS = State->get<AllocatedData>(ArgSM);
   if (!AS)

``````````

</details>


https://github.com/llvm/llvm-project/pull/128642