[clang] Revert partially #127017 (PR #128642)

[Balazs Benics via cfe-commits]

https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/128642

This assertion was hit, as reported by a user.
https://github.com/llvm/llvm-project/issues/128427#issuecomment-2677724438

Ideally, we would reduce and add a regression test for this, but I don't have the bandwidth for it.

See the summary of the issue #128427 for the reproducer.

>From 75f7e74b261ddc619ac6140a3e8fdff56f0960fc Mon Sep 17 00:00:00 2001
From: Balazs Benics <benicsbalazs at gmail.com>
Date: Tue, 25 Feb 2025 08:05:04 +0100
Subject: [PATCH] Revert partially #127017

This assertion was hit, as reported by a user.
https://github.com/llvm/llvm-project/issues/128427#issuecomment-2677724438

Ideally, we would reduce and add a regression test for this, but I don't
have the bandwidth for it.

See the summary of the issue #128427 for the reproducer.
---
 clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp
index 8955cb209c399..12bf12a0b2322 100644
--- a/clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp
@@ -314,7 +314,6 @@ void MacOSKeychainAPIChecker::checkPreStmt(const CallExpr *CE,
     RegionArgIsBad = true;
   }
 
-  assert(ArgSM);
   // Is the argument to the call being tracked?
   const AllocationState *AS = State->get<AllocatedData>(ArgSM);
   if (!AS)