[clang] [clang-linker-wrapper] Avoid repeated hash lookups (NFC) (PR #127443)
via cfe-commits
cfe-commits at lists.llvm.org
Sun Feb 16 22:16:10 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/127443.diff
1 Files Affected:
- (modified) clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp (+3-2)
``````````diff
diff --git a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
index e78763faad73e..7db8f3e27d704 100644
--- a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
+++ b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
@@ -1060,8 +1060,9 @@ Expected<bool> getSymbolsFromBitcode(MemoryBufferRef Buffer, OffloadKind Kind,
if (Sym.isFormatSpecific() || !Sym.isGlobal())
continue;
- bool NewSymbol = Syms.count(Sym.getName()) == 0;
- auto OldSym = NewSymbol ? Sym_None : Syms[Sym.getName()];
+ auto It = Syms.find(Sym.getName());
+ bool NewSymbol = It == Syms.end();
+ auto OldSym = NewSymbol ? Sym_None : It->second;
// We will extract if it defines a currenlty undefined non-weak
// symbol.
``````````
</details>
https://github.com/llvm/llvm-project/pull/127443
More information about the cfe-commits
mailing list