[clang] [clang-linker-wrapper] Avoid repeated hash lookups (NFC) (PR #127443)

Kazu Hirata via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 16 22:15:30 PST 2025


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/127443

None

>From 6002055de10899ee42204dafd8d15fe3318746f8 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sun, 16 Feb 2025 08:25:21 -0800
Subject: [PATCH] [clang-linker-wrapper] Avoid repeated hash lookups (NFC)

---
 clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
index e78763faad73e..7db8f3e27d704 100644
--- a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
+++ b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
@@ -1060,8 +1060,9 @@ Expected<bool> getSymbolsFromBitcode(MemoryBufferRef Buffer, OffloadKind Kind,
       if (Sym.isFormatSpecific() || !Sym.isGlobal())
         continue;
 
-      bool NewSymbol = Syms.count(Sym.getName()) == 0;
-      auto OldSym = NewSymbol ? Sym_None : Syms[Sym.getName()];
+      auto It = Syms.find(Sym.getName());
+      bool NewSymbol = It == Syms.end();
+      auto OldSym = NewSymbol ? Sym_None : It->second;
 
       // We will extract if it defines a currenlty undefined non-weak
       // symbol.



More information about the cfe-commits mailing list