[clang] [ByteCode] Avoid repeated hash lookups (NFC) (PR #126379)
via cfe-commits
cfe-commits at lists.llvm.org
Sat Feb 8 09:19:22 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/126379.diff
1 Files Affected:
- (modified) clang/lib/AST/ByteCode/Program.cpp (+5-7)
``````````diff
diff --git a/clang/lib/AST/ByteCode/Program.cpp b/clang/lib/AST/ByteCode/Program.cpp
index e0b86d46428a26..833c9ef88d770f 100644
--- a/clang/lib/AST/ByteCode/Program.cpp
+++ b/clang/lib/AST/ByteCode/Program.cpp
@@ -18,14 +18,12 @@ using namespace clang;
using namespace clang::interp;
unsigned Program::getOrCreateNativePointer(const void *Ptr) {
- auto It = NativePointerIndices.find(Ptr);
- if (It != NativePointerIndices.end())
- return It->second;
+ auto [It, Inserted] =
+ NativePointerIndices.try_emplace(Ptr, NativePointers.size());
+ if (Inserted)
+ NativePointers.push_back(Ptr);
- unsigned Idx = NativePointers.size();
- NativePointers.push_back(Ptr);
- NativePointerIndices[Ptr] = Idx;
- return Idx;
+ return It->second;
}
const void *Program::getNativePointer(unsigned Idx) {
``````````
</details>
https://github.com/llvm/llvm-project/pull/126379
More information about the cfe-commits
mailing list