[clang] [ByteCode] Avoid repeated hash lookups (NFC) (PR #126379)
Kazu Hirata via cfe-commits
cfe-commits at lists.llvm.org
Sat Feb 8 09:18:51 PST 2025
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/126379
None
>From 5f7f1eb799ce24dfa065816a7ed9772cd256f501 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sat, 8 Feb 2025 00:52:15 -0800
Subject: [PATCH] [ByteCode] Avoid repeated hash lookups (NFC)
---
clang/lib/AST/ByteCode/Program.cpp | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/clang/lib/AST/ByteCode/Program.cpp b/clang/lib/AST/ByteCode/Program.cpp
index e0b86d46428a266..833c9ef88d770f9 100644
--- a/clang/lib/AST/ByteCode/Program.cpp
+++ b/clang/lib/AST/ByteCode/Program.cpp
@@ -18,14 +18,12 @@ using namespace clang;
using namespace clang::interp;
unsigned Program::getOrCreateNativePointer(const void *Ptr) {
- auto It = NativePointerIndices.find(Ptr);
- if (It != NativePointerIndices.end())
- return It->second;
+ auto [It, Inserted] =
+ NativePointerIndices.try_emplace(Ptr, NativePointers.size());
+ if (Inserted)
+ NativePointers.push_back(Ptr);
- unsigned Idx = NativePointers.size();
- NativePointers.push_back(Ptr);
- NativePointerIndices[Ptr] = Idx;
- return Idx;
+ return It->second;
}
const void *Program::getNativePointer(unsigned Idx) {
More information about the cfe-commits
mailing list