[clang] [clang][bytecode] Remove unnecessary if statement (PR #126223)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 7 02:49:29 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
<details>
<summary>Changes</summary>
This doesn't seem to do any good and breaks a few libc++ tests. Remove the special case.
---
Full diff: https://github.com/llvm/llvm-project/pull/126223.diff
1 Files Affected:
- (modified) clang/lib/AST/ByteCode/Compiler.cpp (-3)
``````````diff
diff --git a/clang/lib/AST/ByteCode/Compiler.cpp b/clang/lib/AST/ByteCode/Compiler.cpp
index 1e1e96a1c4782f4..1f0e022edcd7687 100644
--- a/clang/lib/AST/ByteCode/Compiler.cpp
+++ b/clang/lib/AST/ByteCode/Compiler.cpp
@@ -6234,9 +6234,6 @@ bool Compiler<Emitter>::visitDeclRef(const ValueDecl *D, const Expr *E) {
return this->emitGetPtrParam(It->second.Offset, E);
}
-
- if (D->getType()->isReferenceType())
- return this->emitDummyPtr(D, E);
}
// In case we need to re-visit a declaration.
``````````
</details>
https://github.com/llvm/llvm-project/pull/126223
More information about the cfe-commits
mailing list