[clang] [clang][bytecode] Remove unnecessary if statement (PR #126223)

Timm Baeder via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 7 02:48:54 PST 2025


https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/126223

This doesn't seem to do any good and breaks a few libc++ tests. Remove the special case.

>From af446487c0a09760bda3a8bb646b19015b736971 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?= <tbaeder at redhat.com>
Date: Fri, 7 Feb 2025 11:38:04 +0100
Subject: [PATCH] [clang][bytecode] Remove unnecessary if statement

This doesn't seem to do any good and breaks a few libc++ tests. Remove
the special case.
---
 clang/lib/AST/ByteCode/Compiler.cpp | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/clang/lib/AST/ByteCode/Compiler.cpp b/clang/lib/AST/ByteCode/Compiler.cpp
index 1e1e96a1c4782f4..1f0e022edcd7687 100644
--- a/clang/lib/AST/ByteCode/Compiler.cpp
+++ b/clang/lib/AST/ByteCode/Compiler.cpp
@@ -6234,9 +6234,6 @@ bool Compiler<Emitter>::visitDeclRef(const ValueDecl *D, const Expr *E) {
 
       return this->emitGetPtrParam(It->second.Offset, E);
     }
-
-    if (D->getType()->isReferenceType())
-      return this->emitDummyPtr(D, E);
   }
 
   // In case we need to re-visit a declaration.



More information about the cfe-commits mailing list