[clang] [clang] print correct context for diagnostics suppressed by deduction (PR #125453)

[Erich Keane via cfe-commits]

================
@@ -1909,7 +1909,19 @@ class Sema final : public SemaBase {
   /// '\#pragma clang attribute push' directives to the given declaration.
   void AddPragmaAttributes(Scope *S, Decl *D);
 
-  void PrintPragmaAttributeInstantiationPoint();
+  using DiagFuncRef =
+      llvm::function_ref<void(SourceLocation, PartialDiagnostic)>;
+  auto getDefaultDiagFunc() {
+    return [this](SourceLocation Loc, PartialDiagnostic PD) {
+      DiagnosticBuilder Builder(Diags.Report(Loc, PD.getDiagID()));
----------------
erichkeane wrote:

Could this just be `this->Diag(Loc, PD);` ?? Or is there a reason for a new Diag-builder/emit call?  It looks like you're capturing `Sema` anyway.

https://github.com/llvm/llvm-project/pull/125453