[clang] [clang analyzer]consume `llvm::Error` (PR #120597)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Congcong Cai (HerrCai0907)

<details>
<summary>Changes</summary>

`llvm::Error` must be consumed, otherwise it will cause trap during destructor


---
Full diff: https://github.com/llvm/llvm-project/pull/120597.diff


1 Files Affected:

- (modified) clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp (+1-1) 


``````````diff
diff --git a/clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp b/clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp
index 71268af22e2424..e8cf367b833467 100644
--- a/clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp
+++ b/clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp
@@ -81,7 +81,7 @@ class TextDiagnostics : public PathDiagnosticConsumer {
 
         if (llvm::Error Err = Repls.add(Repl)) {
           llvm::errs() << "Error applying replacement " << Repl.toString()
-                       << ": " << Err << "\n";
+                       << ": " << llvm::toString(std::move(Err)) << "\n";
         }
       }
     };

``````````

</details>


https://github.com/llvm/llvm-project/pull/120597