[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

Matt Arsenault via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 17 07:08:58 PST 2024


================
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts,
     break;
   }
 
-  if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) {
+  // OpenCL assumes by default that atomic scopes are per-address space for
+  // non-sequentially consistent operations.
+  if (Scope >= SyncScope::OpenCLWorkGroup &&
----------------
arsenm wrote:

> less friction to just leave it there.

This is how we just end up with an ever-growing pile of garbage nobody understands. Just rip it out. 

https://github.com/llvm/llvm-project/pull/120095


More information about the cfe-commits mailing list