[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)
Joseph Huber via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 17 07:03:04 PST 2024
================
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts,
break;
}
- if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) {
+ // OpenCL assumes by default that atomic scopes are per-address space for
+ // non-sequentially consistent operations.
+ if (Scope >= SyncScope::OpenCLWorkGroup &&
----------------
jhuber6 wrote:
I'm fine with whatever makes C/C++ correct, OpenCL seems to do their own thing so I figured it's less friction to just leave it there.
https://github.com/llvm/llvm-project/pull/120095
More information about the cfe-commits
mailing list