[clang] [Clang] [Parser] Fixing all callers of `ParseExternalDeclaration` that didn't parse gnu attributes (PR #117148)
Erich Keane via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 25 10:32:34 PST 2024
================
@@ -2314,10 +2314,12 @@ Parser::DeclGroupPtrTy Parser::ParseOpenMPDeclarativeDirectiveWithExtDecl(
// Here we expect to see some function declaration.
if (AS == AS_none) {
assert(TagType == DeclSpec::TST_unspecified);
- ParsedAttributes EmptyDeclSpecAttrs(AttrFactory);
- MaybeParseCXX11Attributes(Attrs);
+ ParsedAttributes DeclSpecAttrs(AttrFactory);
----------------
erichkeane wrote:
Ah! I missed that, thanks! @alexey-bataev : Are we sure this is intentional? Basically, we perhaps should be parsing these attributes 'together', and it isn't clear to me looking at this that this doesn't 'fix' a bug/should have some attention.
https://github.com/llvm/llvm-project/pull/117148
More information about the cfe-commits
mailing list