[clang] [Clang] [Parser] Fixing all callers of `ParseExternalDeclaration` that didn't parse gnu attributes (PR #117148)

Mathys Gasnier via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 25 10:30:29 PST 2024


================
@@ -480,10 +468,7 @@ Decl *Parser::ParseExportDeclaration() {
 
   while (!tryParseMisplacedModuleImport() && Tok.isNot(tok::r_brace) &&
          Tok.isNot(tok::eof)) {
-    ParsedAttributes DeclAttrs(AttrFactory);
-    MaybeParseCXX11Attributes(DeclAttrs);
----------------
Mathys-Gasnier wrote:

Probably not, some place still use it, and we aren't able to replace it with the new function due to branching depending on different tokens. For example see ParseDeclCXX.cpp in `ParseLinkage`

https://github.com/llvm/llvm-project/pull/117148


More information about the cfe-commits mailing list