[clang-tools-extra] [clang-tidy] Add recursion protection in ExceptionSpecAnalyzer (PR #66810)
Julian Schmidt via cfe-commits
cfe-commits at lists.llvm.org
Sun Nov 24 12:00:04 PST 2024
https://github.com/5chmidti commented:
> Being totally unfamiliar with the code, I have a feeling that we shouldn't be fixing in the analyze function. analyze has 1 single responsibility: wrap `analyzeImpl` in order to add cacheability for performance reasons, it does so simply and well, and it does exactly what one would expect - no more no less.
This class could maintain a stack-like `SmallVector` to check for an infinite recursion., so instead of checking the function cache (which might be large), only a few functions have to be compared this way.
https://github.com/llvm/llvm-project/pull/66810
More information about the cfe-commits
mailing list