[clang] [Clang] Improve EmitClangAttrSpellingListIndex (PR #114899)

Thu Nov 7 16:00:16 PST 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast` running on `gribozavr4` while building `clang` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/11711

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
4.017 [5248/71/719] Building SystemZGenDAGISel.inc...
4.022 [5248/70/720] Building XCoreGenDisassemblerTables.inc...
4.023 [5248/69/721] Building PPCGenGlobalISel.inc...
4.035 [5248/68/722] Building WebAssemblyGenDAGISel.inc...
4.051 [5248/67/723] Building SystemZGenDisassemblerTables.inc...
4.075 [5248/66/724] Building AArch64GenFastISel.inc...
4.088 [5248/65/725] Building XCoreGenSubtargetInfo.inc...
4.165 [5248/64/726] Building XCoreGenRegisterInfo.inc...
4.185 [5248/63/727] Building XCoreGenDAGISel.inc...
4.258 [5248/62/728] Building CXX object tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangAttrEmitter.cpp.o
FAILED: tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangAttrEmitter.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/1/clang-x86_64-debian-fast/llvm.obj/tools/clang/utils/TableGen -I/b/1/clang-x86_64-debian-fast/llvm.src/clang/utils/TableGen -I/b/1/clang-x86_64-debian-fast/llvm.src/clang/include -I/b/1/clang-x86_64-debian-fast/llvm.obj/tools/clang/include -I/b/1/clang-x86_64-debian-fast/llvm.obj/include -I/b/1/clang-x86_64-debian-fast/llvm.src/llvm/include -std=c++11 -Wdocumentation -Wno-documentation-deprecated-sync -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangAttrEmitter.cpp.o -MF tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangAttrEmitter.cpp.o.d -o tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangAttrEmitter.cpp.o -c /b/1/clang-x86_64-debian-fast/llvm.src/clang/utils/TableGen/ClangAttrEmitter.cpp
/b/1/clang-x86_64-debian-fast/llvm.src/clang/utils/TableGen/ClangAttrEmitter.cpp:3869:51: error: reference to local binding 'FS' declared in enclosing function 'clang::EmitClangAttrSpellingListIndex'
            [&](StringRef N) { return N.size() == FS.name().size(); });
                                                  ^
/b/1/clang-x86_64-debian-fast/llvm.src/clang/utils/TableGen/ClangAttrEmitter.cpp:3863:28: note: 'FS' declared here
    for (const auto &[Idx, FS] : enumerate(Spellings)) {
                           ^
1 error generated.
4.260 [5248/61/729] Building WebAssemblyGenInstrInfo.inc...
4.265 [5248/60/730] Building XCoreGenInstrInfo.inc...
4.372 [5248/59/731] Building PPCGenDAGISel.inc...
4.407 [5248/58/732] Building X86GenRegisterInfo.inc...
4.411 [5248/57/733] Building X86GenRegisterBank.inc...
4.459 [5248/56/734] Building NVPTXGenInstrInfo.inc...
4.573 [5248/55/735] Building NVPTXGenDAGISel.inc...
4.688 [5248/54/736] Building SystemZGenSubtargetInfo.inc...
4.821 [5248/53/737] Building RISCVTargetParserDef.inc...
4.854 [5248/52/738] Building AArch64GenGlobalISel.inc...
4.939 [5248/51/739] Building RISCVGenMacroFusion.inc...
5.020 [5248/50/740] Building SystemZGenInstrInfo.inc...
5.191 [5248/49/741] Building RISCVGenRegisterBank.inc...
5.219 [5248/48/742] Building RISCVGenCompressInstEmitter.inc...
5.236 [5248/47/743] Building X86GenCallingConv.inc...
5.283 [5248/46/744] Building RISCVGenPostLegalizeGICombiner.inc...
5.323 [5248/45/745] Building RISCVGenMCCodeEmitter.inc...
5.326 [5248/44/746] Building RISCVGenO0PreLegalizeGICombiner.inc...
5.334 [5248/43/747] Building RISCVGenRegisterInfo.inc...
5.402 [5248/42/748] Building RISCVGenMCPseudoLowering.inc...
5.415 [5248/41/749] Building RISCVGenDisassemblerTables.inc...
5.470 [5248/40/750] Building RISCVGenPreLegalizeGICombiner.inc...
5.510 [5248/39/751] Building RISCVGenAsmWriter.inc...
5.513 [5248/38/752] Building AArch64GenDAGISel.inc...
5.611 [5248/37/753] Building X86GenExegesis.inc...
5.655 [5248/36/754] Building X86GenAsmWriter.inc...
5.765 [5248/35/755] Building X86GenAsmWriter1.inc...
5.783 [5248/34/756] Building X86GenInstrMapping.inc...
5.927 [5248/33/757] Building X86GenMnemonicTables.inc...
6.023 [5248/32/758] Building RISCVGenAsmMatcher.inc...

```

</details>

https://github.com/llvm/llvm-project/pull/114899