[clang] [Clang] Improve EmitClangAttrSpellingListIndex (PR #114899)

Thu Nov 7 15:59:06 PST 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `clang` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/12164

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
6.141 [6301/96/631] Building HexagonGenSubtargetInfo.inc...
6.162 [6300/96/632] Building PPCGenExegesis.inc...
6.292 [6299/96/633] Building SystemZGenSubtargetInfo.inc...
6.298 [6298/96/634] Building ARMGenSubtargetInfo.inc...
6.326 [6297/96/635] Building PPCGenDisassemblerTables.inc...
6.332 [6296/96/636] Building PPCGenAsmMatcher.inc...
6.396 [6295/96/637] Building ARMGenDAGISel.inc...
6.422 [6294/96/638] Building PPCGenRegisterInfo.inc...
6.446 [6293/96/639] Building PPCGenCallingConv.inc...
6.473 [6292/96/640] Building CXX object tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangAttrEmitter.cpp.o
FAILED: tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangAttrEmitter.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/1/llvm-x86_64-debian-dylib/build/tools/clang/utils/TableGen -I/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/utils/TableGen -I/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/include -I/b/1/llvm-x86_64-debian-dylib/build/tools/clang/include -I/b/1/llvm-x86_64-debian-dylib/build/include -I/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangAttrEmitter.cpp.o -MF tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangAttrEmitter.cpp.o.d -o tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangAttrEmitter.cpp.o -c /b/1/llvm-x86_64-debian-dylib/llvm-project/clang/utils/TableGen/ClangAttrEmitter.cpp
/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/utils/TableGen/ClangAttrEmitter.cpp:3869:51: error: reference to local binding 'FS' declared in enclosing function 'clang::EmitClangAttrSpellingListIndex'
            [&](StringRef N) { return N.size() == FS.name().size(); });
                                                  ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/utils/TableGen/ClangAttrEmitter.cpp:3863:28: note: 'FS' declared here
    for (const auto &[Idx, FS] : enumerate(Spellings)) {
                           ^
1 error generated.
6.479 [6292/95/641] Building MipsGenSubtargetInfo.inc...
6.538 [6292/94/642] Building SparcGenAsmWriter.inc...
6.557 [6292/93/643] Building SparcGenDisassemblerTables.inc...
6.566 [6292/92/644] Building ARMGenGlobalISel.inc...
6.589 [6292/91/645] Building NVPTXGenRegisterInfo.inc...
6.642 [6292/90/646] Building SystemZGenInstrInfo.inc...
6.660 [6292/89/647] Building LoongArchGenDAGISel.inc...
6.662 [6292/88/648] Building SparcGenCallingConv.inc...
6.750 [6292/87/649] Building PPCGenAsmWriter.inc...
6.851 [6292/86/650] Building MipsGenFastISel.inc...
6.862 [6292/85/651] Building SparcGenAsmMatcher.inc...
6.884 [6292/84/652] Building SparcGenSubtargetInfo.inc...
6.913 [6292/83/653] Building NVPTXGenAsmWriter.inc...
6.914 [6292/82/654] Building SparcGenDAGISel.inc...
6.925 [6292/81/655] Building SparcGenRegisterInfo.inc...
6.984 [6292/80/656] Building SparcGenSearchableTables.inc...
6.995 [6292/79/657] Building MipsGenGlobalISel.inc...
7.012 [6292/78/658] Building MipsGenDAGISel.inc...
7.091 [6292/77/659] Building WebAssemblyGenAsmWriter.inc...
7.128 [6292/76/660] Building WebAssemblyGenMCCodeEmitter.inc...
7.156 [6292/75/661] Building PPCGenSubtargetInfo.inc...
7.205 [6292/74/662] Building HexagonGenDAGISel.inc...
7.222 [6292/73/663] Building WebAssemblyGenAsmMatcher.inc...
7.256 [6292/72/664] Building WebAssemblyGenRegisterInfo.inc...
7.279 [6292/71/665] Building WebAssemblyGenDisassemblerTables.inc...
7.315 [6292/70/666] Building NVPTXGenSubtargetInfo.inc...
7.446 [6292/69/667] Building AArch64GenFastISel.inc...
7.476 [6292/68/668] Building VEGenCallingConv.inc...
7.528 [6292/67/669] Building WebAssemblyGenDAGISel.inc...
7.538 [6292/66/670] Building MipsGenInstrInfo.inc...

```

</details>

https://github.com/llvm/llvm-project/pull/114899