[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

Paul Walker via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 10 10:26:33 PDT 2024


================
@@ -1391,7 +1391,8 @@ void ASTContext::InitBuiltinTypes(const TargetInfo &Target,
   }
 
   if (Target.hasAArch64SVETypes() ||
-      (AuxTarget && AuxTarget->hasAArch64SVETypes())) {
+      (AuxTarget && AuxTarget->hasAArch64SVETypes()) ||
+      Target.hasArmMFloat8Type()) {
----------------
paulwalker-arm wrote:

This might be a bum steer but I'm wondering if `Target.hasArmMFloat8Type()` is needed here.  If you ignore the name I think `hasAArch64SVETypes()` effectively means "are_the_types_defined_in_AArch64SVEACLETypes.def_available?".

If you agree that the new types should not be hidden behind a feature flag then perhaps the original code just works without alteration.

https://github.com/llvm/llvm-project/pull/97277


More information about the cfe-commits mailing list