[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

Paul Walker via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 10 10:26:33 PDT 2024


================
@@ -2218,6 +2219,11 @@ TypeInfo ASTContext::getTypeInfoImpl(const Type *T) const {
     Width = 0;                                                                 \
     Align = 16;                                                                \
     break;
+#define AARCH64_SCALAR_TYPE(Acronym, Name, MangledName, Id, SingletonId)
----------------
paulwalker-arm wrote:

What I meant with my previous comment is that it seems odd to set the define but then have specify the case block separately, whereas I'd expect something like
```
#define AARCH64_SCALAR_TYPE(Acronym, Name, MangledName, Id, SingletonId) \
  case BuiltinType::Id: \
       Width = 8; \
       Align = 8; \
       break;
```
Note I've used `8` rather than `getChar...`, which is because I don't really know what those functions do and we know for mfloat8_t we want the exact value of 8.

https://github.com/llvm/llvm-project/pull/97277


More information about the cfe-commits mailing list