[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)
Michal Paszkowski via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 1 22:40:09 PDT 2024
================
@@ -1,56 +0,0 @@
-; This test aims to check ability to support "Arithmetic with Overflow" intrinsics
----------------
michalpaszkowski wrote:
@AlexVlx I am not sure I follow the reasoning here. The idea behind those various tests in `/SPIRV/optimizations/` (including this one) is to ensure the backend can accept any IR. Either coming from the standard -O3 or some custom pipeline.
I do agree that we should not expect specific optimizations (or even more sets of optimizations) to do specific things when writing a test for an independent component. Hence, after some thinking, I believe the test could be improved by already containing a specific pattern that would be coming from the optimization. However, by the same principle, we should not expect that the issue will be "optimized away" by another optimization.
I would also oppose removing existing test cases. Any improvements, strengthening, or necessary changes are (of course) desirable.
https://github.com/llvm/llvm-project/pull/110695
More information about the cfe-commits
mailing list