[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

kadir çetinkaya via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 26 23:49:03 PDT 2024


================
@@ -2108,7 +2116,7 @@ class CodeCompleteFlow {
 
 } // namespace
 
-clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts() const {
+clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts(bool ForceLoadExternal) const {
----------------
kadircet wrote:

> we may need to update all the places using clangd::CodeCompleteOptions

i don't follow this one, i'd expect us to just set it once in ClangdMain.cpp, with other CodeCompleteOpts fields we set based on command line flags/configs and use it only once in `CodeCompleteOptions::getClangCompleteOpts` (modulo tests that're specifically testing this behavior, not even all the tests).

What are the other places that need updating?

https://github.com/llvm/llvm-project/pull/110083


More information about the cfe-commits mailing list