[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)
Chuanqi Xu via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 26 19:24:15 PDT 2024
================
@@ -2108,7 +2116,7 @@ class CodeCompleteFlow {
} // namespace
-clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts() const {
+clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts(bool ForceLoadExternal) const {
----------------
ChuanqiXu9 wrote:
I found the `CodeCompleteOptions` are passing to `codeComplete`. So if we pass the information if modules are enabled when initialize `clangd::CodeCompleteOptions`, we may need to update all the places using `clangd::CodeCompleteOptions`. I feel it is bigger but unnecessary change. I don't feel bad with the current style. WDYT?
https://github.com/llvm/llvm-project/pull/110083
More information about the cfe-commits
mailing list