[clang] fix update-verify-tests test suite for AIX (PR #108871)

via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 16 11:48:59 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Henrik G. Olsson (hnrklssn)

<details>
<summary>Changes</summary>

The diff command on AIX doesn't support the --strip-trailing-cr flag. The internal python implementation does, so execute the tests in the update-verify-tests test suite using the internal shell for compatibility.

---
Full diff: https://github.com/llvm/llvm-project/pull/108871.diff


1 Files Affected:

- (modified) clang/test/utils/update-verify-tests/lit.local.cfg (+3) 


``````````diff
diff --git a/clang/test/utils/update-verify-tests/lit.local.cfg b/clang/test/utils/update-verify-tests/lit.local.cfg
index a0b6afccc25010..b0eebf337da5c9 100644
--- a/clang/test/utils/update-verify-tests/lit.local.cfg
+++ b/clang/test/utils/update-verify-tests/lit.local.cfg
@@ -23,3 +23,6 @@ else:
             "%s %s" % (python, shell_quote(script_path)),
         )
     )
+    # AIX 'diff' command doesn't support --strip-trailing-cr, but the internal
+    # python implementation does, so use that for cross platform compatibility
+    config.test_format = lit.formats.ShTest()

``````````

</details>


https://github.com/llvm/llvm-project/pull/108871


More information about the cfe-commits mailing list