[clang] fix update-verify-tests test suite for AIX (PR #108871)

Henrik G. Olsson via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 16 11:48:27 PDT 2024


https://github.com/hnrklssn created https://github.com/llvm/llvm-project/pull/108871

The diff command on AIX doesn't support the --strip-trailing-cr flag. The internal python implementation does, so execute the tests in the update-verify-tests test suite using the internal shell for compatibility.

>From 9b1a291017aa599d560e4fdbd30e3d5ef8fc3937 Mon Sep 17 00:00:00 2001
From: "Henrik G. Olsson" <h_olsson at apple.com>
Date: Mon, 16 Sep 2024 11:42:35 -0700
Subject: [PATCH] fix update-verify-tests test suite for AIX

The diff command on AIX doesn't support the --strip-trailing-cr flag.
The internal python implementation does, so execute the tests in the
update-verify-tests test suite using the internal shell for
compatibility.
---
 clang/test/utils/update-verify-tests/lit.local.cfg | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/clang/test/utils/update-verify-tests/lit.local.cfg b/clang/test/utils/update-verify-tests/lit.local.cfg
index a0b6afccc25010..b0eebf337da5c9 100644
--- a/clang/test/utils/update-verify-tests/lit.local.cfg
+++ b/clang/test/utils/update-verify-tests/lit.local.cfg
@@ -23,3 +23,6 @@ else:
             "%s %s" % (python, shell_quote(script_path)),
         )
     )
+    # AIX 'diff' command doesn't support --strip-trailing-cr, but the internal
+    # python implementation does, so use that for cross platform compatibility
+    config.test_format = lit.formats.ShTest()



More information about the cfe-commits mailing list