[clang] [clang][ExtractAPI] Stop dropping fields of nested anonymous record types when they aren't attached to variable declaration (PR #104600)

[LLVM Continuous Integration via cfe-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-aarch64-libcxx` running on `linaro-flang-aarch64-libcxx` while building `clang` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/89/builds/4430

Here is the relevant piece of the build log for the reference:
```
Step 5 (build-unified-tree) failure: build (failure)
...
63.406 [170/5/6960] Linking CXX shared library lib/libFIRTransforms.so.20.0git
63.412 [169/5/6961] Creating library symlink lib/libFIRTransforms.so
63.450 [167/6/6962] Building CXX object tools/clang/lib/FrontendTool/CMakeFiles/obj.clangFrontendTool.dir/ExecuteCompilerInvocation.cpp.o
63.654 [167/5/6963] Linking CXX shared library lib/libFIRTestAnalysis.so.20.0git
63.660 [166/5/6964] Creating library symlink lib/libFIRTestAnalysis.so
63.951 [166/4/6965] Linking CXX shared library lib/libHLFIRTransforms.so.20.0git
63.957 [165/4/6966] Creating library symlink lib/libHLFIRTransforms.so
64.708 [163/5/6967] Linking CXX executable bin/tco
64.793 [163/4/6968] Linking CXX executable bin/fir-opt
65.681 [163/3/6969] Building CXX object tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.o
FAILED: tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.o 
/usr/local/bin/c++ -DGTEST_HAS_RTTI=0 -D_CINDEX_LIB_ -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/tools/clang/tools/libclang -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/clang/tools/libclang -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/clang/include -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/tools/clang/include -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/include -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/llvm/include -stdlib=libc++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17 -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.o -MF tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.o.d -o tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.o -c /home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/clang/tools/libclang/CXExtractAPI.cpp
In file included from ../llvm-project/clang/tools/libclang/CXExtractAPI.cpp:25:
../llvm-project/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:164:38: error: member access into incomplete type 'SourceManager'
  164 |     return Context.getSourceManager().isInSystemHeader(D->getLocation());
      |                                      ^
../llvm-project/clang/include/clang/Basic/SourceLocation.h:34:7: note: forward declaration of 'clang::SourceManager'
   34 | class SourceManager;
      |       ^
In file included from ../llvm-project/clang/tools/libclang/CXExtractAPI.cpp:25:
../llvm-project/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:293:33: error: member access into incomplete type 'SourceManager'
  293 |       Context.getSourceManager().getPresumedLoc(Decl->getLocation());
      |                                 ^
../llvm-project/clang/include/clang/Basic/SourceLocation.h:34:7: note: forward declaration of 'clang::SourceManager'
   34 | class SourceManager;
      |       ^
In file included from ../llvm-project/clang/tools/libclang/CXExtractAPI.cpp:25:
../llvm-project/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:366:33: error: member access into incomplete type 'SourceManager'
  366 |       Context.getSourceManager().getPresumedLoc(Decl->getLocation());
      |                                 ^
../llvm-project/clang/include/clang/Basic/SourceLocation.h:34:7: note: forward declaration of 'clang::SourceManager'
   34 | class SourceManager;
      |       ^
In file included from ../llvm-project/clang/tools/libclang/CXExtractAPI.cpp:25:
../llvm-project/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:404:33: error: member access into incomplete type 'SourceManager'
  404 |       Context.getSourceManager().getPresumedLoc(Decl->getLocation());
      |                                 ^
../llvm-project/clang/include/clang/Basic/SourceLocation.h:34:7: note: forward declaration of 'clang::SourceManager'
   34 | class SourceManager;
      |       ^
In file included from ../llvm-project/clang/tools/libclang/CXExtractAPI.cpp:25:
../llvm-project/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:535:33: error: member access into incomplete type 'SourceManager'
  535 |       Context.getSourceManager().getPresumedLoc(Decl->getLocation());
      |                                 ^
../llvm-project/clang/include/clang/Basic/SourceLocation.h:34:7: note: forward declaration of 'clang::SourceManager'
   34 | class SourceManager;
      |       ^
In file included from ../llvm-project/clang/tools/libclang/CXExtractAPI.cpp:25:
../llvm-project/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:581:33: error: member access into incomplete type 'SourceManager'

```

https://github.com/llvm/llvm-project/pull/104600