[clang] [clang][ExtractAPI] Stop dropping fields of nested anonymous record types when they aren't attached to variable declaration (PR #104600)

Mon Aug 19 08:01:55 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast` running on `gribozavr4` while building `clang` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/5210

Here is the relevant piece of the build log for the reference:
```
Step 5 (build-unified-tree) failure: build (failure)
...
40.251 [32/11/5929] Building CXX object tools/bugpoint-passes/CMakeFiles/BugpointPasses.dir/TestPasses.cpp.o
40.277 [31/11/5930] Linking CXX shared module lib/BugpointPasses.so
40.366 [31/10/5931] Linking CXX executable bin/llvm-lto2
40.447 [31/9/5932] Linking CXX executable bin/clang-linker-wrapper
40.465 [31/8/5933] Linking CXX executable bin/clangd-indexer
40.841 [31/7/5934] Linking CXX shared library lib/libLTO.so.20.0git
40.843 [30/7/5935] Creating library symlink lib/libLTO.so
41.120 [30/6/5936] Linking CXX executable bin/clang-scan-deps
41.434 [30/5/5937] Linking CXX executable bin/clang-check
42.144 [30/4/5938] Building CXX object tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.o
FAILED: tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D_CINDEX_LIB_ -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/1/clang-x86_64-debian-fast/llvm.obj/tools/clang/tools/libclang -I/b/1/clang-x86_64-debian-fast/llvm.src/clang/tools/libclang -I/b/1/clang-x86_64-debian-fast/llvm.src/clang/include -I/b/1/clang-x86_64-debian-fast/llvm.obj/tools/clang/include -I/b/1/clang-x86_64-debian-fast/llvm.obj/include -I/b/1/clang-x86_64-debian-fast/llvm.src/llvm/include -std=c++11 -Wdocumentation -Wno-documentation-deprecated-sync -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.o -MF tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.o.d -o tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.o -c /b/1/clang-x86_64-debian-fast/llvm.src/clang/tools/libclang/CXExtractAPI.cpp
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/clang/tools/libclang/CXExtractAPI.cpp:24:
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/ExtractAPI/API.h:25:
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/ExtractAPI/DeclarationFragments.h:23:
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/AST/DeclCXX.h:22:
/b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/AST/Expr.h:5171:21: warning: '@endcode' command does not terminate a verbatim text block [-Wdocumentation]
  /// literal or an @encode?
                    ^~~~~~~
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/clang/tools/libclang/CXExtractAPI.cpp:25:
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:23:
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/AST/RecursiveASTVisitor.h:23:
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/AST/DeclOpenMP.h:21:
/b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/AST/OpenMPClause.h:6409:20: warning: empty paragraph passed to '\param' command [-Wdocumentation]
  /// \param PreInit
      ~~~~~~~~~~~~~^
/b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/AST/OpenMPClause.h:6503:20: warning: empty paragraph passed to '\param' command [-Wdocumentation]
  /// \param PreInit
      ~~~~~~~~~~~~~^
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/clang/tools/libclang/CXExtractAPI.cpp:25:
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:23:
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/AST/RecursiveASTVisitor.h:39:
/b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/AST/StmtOpenMP.h:5744:14: warning: parameter 'NumClauses' not found in the function declaration [-Wdocumentation]
  /// \param NumClauses Number of clauses to allocate.
             ^~~~~~~~~~
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/clang/tools/libclang/CXExtractAPI.cpp:25:
/b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:164:38: error: member access into incomplete type 'clang::SourceManager'
    return Context.getSourceManager().isInSystemHeader(D->getLocation());
                                     ^
/b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/Basic/SourceLocation.h:34:7: note: forward declaration of 'clang::SourceManager'
class SourceManager;
      ^
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/clang/tools/libclang/CXExtractAPI.cpp:25:
/b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:293:33: error: member access into incomplete type 'clang::SourceManager'
      Context.getSourceManager().getPresumedLoc(Decl->getLocation());
                                ^
/b/1/clang-x86_64-debian-fast/llvm.src/clang/include/clang/Basic/SourceLocation.h:34:7: note: forward declaration of 'clang::SourceManager'
class SourceManager;
      ^

```

https://github.com/llvm/llvm-project/pull/104600