[clang] Implement resource binding type prefix mismatch flag setting logic (PR #97103)

[Damyan Pepper via cfe-commits]

================
@@ -38,6 +57,10 @@ Decl *SemaHLSL::ActOnStartBuffer(Scope *BufferScope, bool CBuffer,
   HLSLBufferDecl *Result = HLSLBufferDecl::Create(
       getASTContext(), LexicalParent, CBuffer, KwLoc, Ident, IdentLoc, LBrace);
 
+  HLSLResourceAttr *NewAttr = mergeHLSLResourceAttr(CBuffer);
+  if (NewAttr)
----------------
damyanp wrote:

When would NewAttr ever be null and we want to quietly ignore it and carry on?  

(also, see above comment about inlining `mergeHLSLResourceAttr` here - if you were to do that then this comment would be moot)

https://github.com/llvm/llvm-project/pull/97103