[clang] [clang] Fix incomplete umbrella warnings when building clang modules (NFC) (PR #96939)

Med Ismail Bennani via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 27 11:33:14 PDT 2024


https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/96939

>From 7d0a3e33840db80344075696726de1bf46a62861 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani <ismail at bennani.ma>
Date: Thu, 27 Jun 2024 11:30:05 -0700
Subject: [PATCH] [clang] Fix incomplete umbrella warnings when building clang
 modules (NFC)

This patch silences the incomplete-umbrella warnings when building clang
modules, by adding and sorting the missing textual headers to the clang
module map.

Signed-off-by: Med Ismail Bennani <ismail at bennani.ma>
---
 clang/include/module.modulemap | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/clang/include/module.modulemap b/clang/include/module.modulemap
index acd960c9c932a..00ecd47d35b62 100644
--- a/clang/include/module.modulemap
+++ b/clang/include/module.modulemap
@@ -37,19 +37,20 @@ module Clang_Basic {
   umbrella "clang/Basic"
 
   textual header "clang/Basic/AArch64SVEACLETypes.def"
+  textual header "clang/Basic/AMDGPUTypes.def"
+  textual header "clang/Basic/BuiltinHeaders.def"
   textual header "clang/Basic/BuiltinsAArch64.def"
-  textual header "clang/Basic/BuiltinsAMDGPU.def"
   textual header "clang/Basic/BuiltinsAArch64NeonSVEBridge.def"
   textual header "clang/Basic/BuiltinsAArch64NeonSVEBridge_cg.def"
+  textual header "clang/Basic/BuiltinsAMDGPU.def"
   textual header "clang/Basic/BuiltinsARM.def"
-  textual header "clang/Basic/BuiltinHeaders.def"
   textual header "clang/Basic/BuiltinsHexagon.def"
   textual header "clang/Basic/BuiltinsHexagonDep.def"
   textual header "clang/Basic/BuiltinsHexagonMapCustomDep.def"
   textual header "clang/Basic/BuiltinsLoongArch.def"
   textual header "clang/Basic/BuiltinsLoongArchBase.def"
-  textual header "clang/Basic/BuiltinsLoongArchLSX.def"
   textual header "clang/Basic/BuiltinsLoongArchLASX.def"
+  textual header "clang/Basic/BuiltinsLoongArchLSX.def"
   textual header "clang/Basic/BuiltinsMips.def"
   textual header "clang/Basic/BuiltinsNEON.def"
   textual header "clang/Basic/BuiltinsNVPTX.def"
@@ -67,13 +68,14 @@ module Clang_Basic {
   textual header "clang/Basic/CodeGenOptions.def"
   textual header "clang/Basic/DebugOptions.def"
   textual header "clang/Basic/DiagnosticOptions.def"
-  textual header "clang/Basic/Features.def"
   textual header "clang/Basic/FPOptions.def"
-  textual header "clang/Basic/MSP430Target.def"
+  textual header "clang/Basic/Features.def"
   textual header "clang/Basic/LangOptions.def"
+  textual header "clang/Basic/MSP430Target.def"
+  textual header "clang/Basic/OpenACCClauses.def"
+  textual header "clang/Basic/OpenCLExtensionTypes.def"
   textual header "clang/Basic/OpenCLExtensions.def"
   textual header "clang/Basic/OpenCLImageTypes.def"
-  textual header "clang/Basic/OpenCLExtensionTypes.def"
   textual header "clang/Basic/OpenMPKinds.def"
   textual header "clang/Basic/OperatorKinds.def"
   textual header "clang/Basic/PPCTypes.def"
@@ -81,8 +83,8 @@ module Clang_Basic {
   textual header "clang/Basic/Sanitizers.def"
   textual header "clang/Basic/TargetCXXABI.def"
   textual header "clang/Basic/TargetOSMacros.def"
-  textual header "clang/Basic/TransformTypeTraits.def"
   textual header "clang/Basic/TokenKinds.def"
+  textual header "clang/Basic/TransformTypeTraits.def"
   textual header "clang/Basic/WebAssemblyReferenceTypes.def"
 
   module * { export * }



More information about the cfe-commits mailing list