[clang] [clang] Fix incomplete umbrella warnings when building clang modules (NFC) (PR #96939)

via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 27 10:41:26 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Med Ismail Bennani (medismailben)

<details>
<summary>Changes</summary>

This patch silences the incomplete-umbrella warnings when building clang modules, by adding the missing textual headers to the clang module map.

---
Full diff: https://github.com/llvm/llvm-project/pull/96939.diff


1 Files Affected:

- (modified) clang/include/module.modulemap (+2) 


``````````diff
diff --git a/clang/include/module.modulemap b/clang/include/module.modulemap
index acd960c9c932a..a8ee223126690 100644
--- a/clang/include/module.modulemap
+++ b/clang/include/module.modulemap
@@ -22,6 +22,7 @@ module Clang_AST {
   requires cplusplus
   umbrella "clang/AST"
 
+  textual header "clang/Basic/OpenACCClauses.def"
   textual header "clang/AST/BuiltinTypes.def"
   textual header "clang/AST/CXXRecordDeclDefinitionBits.def"
   textual header "clang/AST/OperationKinds.def"
@@ -37,6 +38,7 @@ module Clang_Basic {
   umbrella "clang/Basic"
 
   textual header "clang/Basic/AArch64SVEACLETypes.def"
+  textual header "clang/Basic/AMDGPUTypes.def"
   textual header "clang/Basic/BuiltinsAArch64.def"
   textual header "clang/Basic/BuiltinsAMDGPU.def"
   textual header "clang/Basic/BuiltinsAArch64NeonSVEBridge.def"

``````````

</details>


https://github.com/llvm/llvm-project/pull/96939


More information about the cfe-commits mailing list