[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

[via cfe-commits]

Sirraide wrote:

> Can we revert and consider other approaches?

Yeah, a lot of the points you’ve brought up make sense, and if you’re saying it’s a bad idea then I’ll trust you and revert this for now so we can think about this some more... 

Also, I suppose part of the issue for me at least was that I wasn’t 100% sure about this approach either, but I also didn’t want to create even more work for other people than they already have by asking someone else to review this too... I’ll be a bit more careful with this in the future. 

I also marked this as a good first issue because I thought it shouldn’t be that complicated to do this, but it seems I was wrong (this is also why I usually don’t like using that label...)

https://github.com/llvm/llvm-project/pull/94159