[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

[Richard Smith via cfe-commits]

================
@@ -65,8 +65,10 @@ void test4(void) {
 
 void test5(int *X, float *P) {
   (float*)X = P;   // expected-error {{assignment to cast is illegal, lvalue casts are not supported}}
+  // expected-note at -1 {{add '*' to dereference it}}
----------------
zygoloid wrote:

This is a diagnostic regression.

https://github.com/llvm/llvm-project/pull/94159