[clang] [C++20] [Modules] [Itanium ABI] Generate the vtable in the module unit of dynamic classes (PR #75912)

Eli Friedman via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 13 14:37:17 PDT 2024


================
@@ -318,6 +318,9 @@ namespace {
       if (Diags.hasUnrecoverableErrorOccurred())
         return;
 
+      if (RD->shouldEmitInExternalSource())
----------------
efriedma-quic wrote:

The way I see it, Sema should have the exact right answer for whether the vtable is required.  If we need to second-guess the choice later, that means Sema didn't compute the right thing in the first place, which would be a bug in Sema.

https://github.com/llvm/llvm-project/pull/75912


More information about the cfe-commits mailing list