[clang] [C++20] [Modules] [Itanium ABI] Generate the vtable in the module unit of dynamic classes (PR #75912)

Chuanqi Xu via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 12 19:52:06 PDT 2024


================
@@ -318,6 +318,9 @@ namespace {
       if (Diags.hasUnrecoverableErrorOccurred())
         return;
 
+      if (RD->shouldEmitInExternalSource())
----------------
ChuanqiXu9 wrote:

Yes, I think it is not bad to put the check `RD->shouldEmitInExternalSource()` into `HandleVTable`. I feel the most natural logic may be, I see a vtable then I pass it to the consumer and it is the job of the consumer to decide whether or not to emit it. WDYT?

https://github.com/llvm/llvm-project/pull/75912


More information about the cfe-commits mailing list