[clang] [Clang][Sema] Tweak tryCaptureVariable for unevaluated lambdas (PR #93206)
Younan Zhang via cfe-commits
cfe-commits at lists.llvm.org
Sat May 25 23:06:02 PDT 2024
================
@@ -1576,7 +1576,10 @@ ExprResult Parser::ParseLambdaExpressionAfterIntroducer(
TrailingReturnTypeLoc, &DS),
std::move(Attributes), DeclEndLoc);
- Actions.ActOnLambdaClosureQualifiers(Intro, MutableLoc);
+ // We have called ActOnLambdaClosureQualifiers for parentheses-less cases
----------------
zyn0217 wrote:
Yeah, looking into `ActOnLambdaClosureQualifiers`, I don't see anything that (currently) depends on lambda parameters. I guess we can combine these two calls? I'd love to open a separate NFC PR for doing so, before landing this patch. :)
@erichkeane I retrospected your comment in https://github.com/llvm/llvm-project/pull/78598#discussion_r1478458713 and I appreciate the diagnostics for non-ODR uses - however that's much like a QoI issue to me and would it be OK to leave it as a follow-up? Let me know what you think and I'll add a FIXME then.
https://github.com/llvm/llvm-project/pull/93206
More information about the cfe-commits
mailing list