[clang] [NFC][Clang] Use `isa_and_nonnull` instead of `VD && isa<VarDecl>(VD)` (PR #93207)

via cfe-commits cfe-commits at lists.llvm.org
Thu May 23 08:37:18 PDT 2024


https://github.com/yronglin created https://github.com/llvm/llvm-project/pull/93207

This issue was found in https://github.com/llvm/llvm-project/pull/86960. But I'd like to avoid mixing together a bunch of cleanups with actual changes.

>From 6aa4cc4c1fc3309320d949a8c56a662f812e7529 Mon Sep 17 00:00:00 2001
From: yronglin <yronglin777 at gmail.com>
Date: Thu, 23 May 2024 23:33:08 +0800
Subject: [PATCH] [NFC][Clang] Use isa_and_nonnull instead of VD &&
 isa<VarDecl>(VD)

Signed-off-by: yronglin <yronglin777 at gmail.com>
---
 clang/lib/CodeGen/CGExpr.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp
index 4072025376768..d6478cc6835d8 100644
--- a/clang/lib/CodeGen/CGExpr.cpp
+++ b/clang/lib/CodeGen/CGExpr.cpp
@@ -317,8 +317,8 @@ pushTemporaryCleanup(CodeGenFunction &CGF, const MaterializeTemporaryExpr *M,
         CleanupKind CleanupKind;
         if (Lifetime == Qualifiers::OCL_Strong) {
           const ValueDecl *VD = M->getExtendingDecl();
-          bool Precise =
-              VD && isa<VarDecl>(VD) && VD->hasAttr<ObjCPreciseLifetimeAttr>();
+          bool Precise = isa_and_nonnull<VarDecl>(VD) &&
+                         VD->hasAttr<ObjCPreciseLifetimeAttr>();
           CleanupKind = CGF.getARCCleanupKind();
           Destroy = Precise ? &CodeGenFunction::destroyARCStrongPrecise
                             : &CodeGenFunction::destroyARCStrongImprecise;



More information about the cfe-commits mailing list