[clang] [DebugInfo] Add flag to only emit referenced member functions (PR #87018)

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Fri May 24 14:57:52 PDT 2024


dwblaikie wrote:

> I think the comment about `s/members/methods/` is still outstanding - I agree that methods is more descriptive than members.

Yeah, seems I'm outvoted here. I'm a bit of a pedant for the C++ standard language, which doesn't talk about "methods", only "member functions". But anyway, since you're likeyl the first folks to use this, I've made that change toward "methods".

> I'm +1 on having this be non-default; adding it to SCE tuning is also not necessary (or desired) for now, because this is more aggressive than our private option (we keep entries for member functions that are called), and we're still working out whether we can/should adopt this instead.

Yeah, no plans to make this the default any time soon - will start with it entirely off by default, and figured you Sony folks can see if it can be your default in the future - save you carrying the downstream patches, gives you some hope other folks might adopt the same strategy (& folks considering adopting it would have some reassurance that other people are living with it/interested in caring for it already)


https://github.com/llvm/llvm-project/pull/87018


More information about the cfe-commits mailing list