[clang] [lld] [llvm] Run ObjCContractPass in Distributed Thin-LTO Pipeline (PR #92331)

Steven Wu via cfe-commits cfe-commits at lists.llvm.org
Mon May 20 08:52:17 PDT 2024


cachemeifyoucan wrote:

> it seems like this should just be in the default codegen pipeline? you'd need to change the pass to bail out early if there are no relevant intrinsics (by checking if the module contains the intrinsic declaration) to not affect compile times



> it seems like this should just be in the default codegen pipeline? you'd need to change the pass to bail out early if there are no relevant intrinsics (by checking if the module contains the intrinsic declaration) to not affect compile times



> it seems like this should just be in the default codegen pipeline? you'd need to change the pass to bail out early if there are no relevant intrinsics (by checking if the module contains the intrinsic declaration) to not affect compile times

Maybe that is a good idea since the check is already there and the check is quite cheap (just check the existence of ARC intrinsics).

I don't know about how lld is configured, but the concept of the change SGTM. The pass is missing probably because we don't link with distributed thinLTO that uses index-only option.

https://github.com/llvm/llvm-project/pull/92331


More information about the cfe-commits mailing list