[clang] [Sema] Mark alias/ifunc targets used and consider mangled names (PR #87130)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 1 09:09:34 PDT 2024


================
@@ -1980,6 +1981,23 @@ static void handleWeakRefAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
   D->addAttr(::new (S.Context) WeakRefAttr(S.Context, AL));
 }
 
+// Mark alias/ifunc target as used. For C++, we look up the demangled name
+// ignoring parameters. This should handle the majority of use cases while
+// leaveing false positives for namespace scope names and false negatives in
+// the presence of overloads.
+static void markUsedForAliasOrIfunc(Sema &S, Decl *D, const ParsedAttr &AL,
+                                    StringRef Str) {
+  char *Demangled = llvm::itaniumDemangle(Str, /*ParseParams=*/false);
----------------
erichkeane wrote:

Triple is the only way I am aware of IIRC.  So we should be checking that triple.  I think `ifunc` is ELF/Itanium only, and I'm unsure about `alias`.  That said, I'm aware of at least 1 downstream (IIRC) that used an ELF system with an MSVC mangling (one of the offload compilers).

https://github.com/llvm/llvm-project/pull/87130


More information about the cfe-commits mailing list