[clang-tools-extra] [clangd] Fix JSON conversion for symbol tags (PR #84747)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 11 05:06:03 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clangd
@llvm/pr-subscribers-clang-tools-extra
Author: Christian Kandeler (ckandeler)
<details>
<summary>Changes</summary>
The wrong constructor of json::Value got called, making every tag an array instead of a number.
---
Full diff: https://github.com/llvm/llvm-project/pull/84747.diff
1 Files Affected:
- (modified) clang-tools-extra/clangd/Protocol.cpp (+1-1)
``````````diff
diff --git a/clang-tools-extra/clangd/Protocol.cpp b/clang-tools-extra/clangd/Protocol.cpp
index 8aa18bb0058abe..c6553e00dcae28 100644
--- a/clang-tools-extra/clangd/Protocol.cpp
+++ b/clang-tools-extra/clangd/Protocol.cpp
@@ -1412,7 +1412,7 @@ bool fromJSON(const llvm::json::Value &Params, ReferenceParams &R,
}
llvm::json::Value toJSON(SymbolTag Tag) {
- return llvm::json::Value{static_cast<int>(Tag)};
+ return llvm::json::Value(static_cast<int>(Tag));
}
llvm::json::Value toJSON(const CallHierarchyItem &I) {
``````````
</details>
https://github.com/llvm/llvm-project/pull/84747
More information about the cfe-commits
mailing list