[clang-tools-extra] [clangd] Fix JSON conversion for symbol tags (PR #84747)

Christian Kandeler via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 11 05:05:34 PDT 2024


https://github.com/ckandeler created https://github.com/llvm/llvm-project/pull/84747

The wrong constructor of json::Value got called, making every tag an array instead of a number.

>From f67994902314acd8ae0f0c561b07b8c014172e17 Mon Sep 17 00:00:00 2001
From: Christian Kandeler <christian.kandeler at qt.io>
Date: Mon, 11 Mar 2024 13:04:21 +0100
Subject: [PATCH] [clangd] Fix JSON conversion for symbol tags

The wrong constructor of json::Value got called, making every tag an
array instead of a number.
---
 clang-tools-extra/clangd/Protocol.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang-tools-extra/clangd/Protocol.cpp b/clang-tools-extra/clangd/Protocol.cpp
index 8aa18bb0058abe..c6553e00dcae28 100644
--- a/clang-tools-extra/clangd/Protocol.cpp
+++ b/clang-tools-extra/clangd/Protocol.cpp
@@ -1412,7 +1412,7 @@ bool fromJSON(const llvm::json::Value &Params, ReferenceParams &R,
 }
 
 llvm::json::Value toJSON(SymbolTag Tag) {
-  return llvm::json::Value{static_cast<int>(Tag)};
+  return llvm::json::Value(static_cast<int>(Tag));
 }
 
 llvm::json::Value toJSON(const CallHierarchyItem &I) {



More information about the cfe-commits mailing list