[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

Jun Wang via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 6 23:59:05 PST 2024


================
@@ -137,6 +137,12 @@ Removed Compiler Flags
 
 Attribute Changes in Clang
 --------------------------
+- Introduced a new function attribute ``__attribute__((amdgpu_max_num_work_groups(x, y, z)))`` or
----------------
jwanggit86 wrote:

In the case of flat workgroup size, the LLVM attribute is called `amdgpu-flat-work-group-size`, but the metadata is `.max_flat_workgroup_size`. I suppose we can copy that and change the metadata from `.max_num_work_groups_x` to `.max_num_workgoups_x` and so on.

Do you want the LLVM attribute to be changed from `amdgpu-max-num-work-groups` to `amdgpu-max-num-workgroups` as well? Note that in the file `AMDGPUUsage.rst` the word `work-group` with a hyphen is used a lot.

https://github.com/llvm/llvm-project/pull/79035


More information about the cfe-commits mailing list